Hi Carl,
On Thu, Jul 27, 2017 at 01:48:41PM -0700, Carl Love wrote:
> + pat = GEN_FCN (icode) (target, addr);
> + if (! pat)
> + return 0;
No space after "!".
> + /* Reverse element order of elements if in LE mode */
Single space after "/*"; sentences end with dot space space.
> + /* LX_BE We initialized them to always load in big endian order. */
XL_BE.
> + default:
> + break;
> + /* Fall through. */
> + }
"break" is indented one space too many I think?
> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/powerpc/builtins-4-runnable.c
> @@ -0,0 +1,321 @@
> +/* { dg-do run { target { powerpc64*-*-* } } } */
powerpc64*-*-* is pretty much never correct (you can use
powerpc64-linux-gcc -m32 as well as powerpc-linux-gcc -m64). If you
need to restrict a testcase to 64-bit, use an lp64 test. But this
test works everywhere I think? So just powerpc*-*-*, or you can
leave out even that, this is in gcc.target/powerpc.
Looks fine otherwise. Please fix those trivialities and then
commit, thanks!
Segher
