On Tue, Jul 18, 2017 at 1:33 PM, Martin Liška <mli...@suse.cz> wrote:
> Hello.
>
> After we reverted both hunks in gimplify.c, I've just tested with
> --enable-languages=all
> that attached patch works.
>
> May I ask you Eric to fix comment in:
>
> /* The operand may be a void-valued expression such as SAVE_EXPRs
> generated by the Java frontend for class initialization. It is
> being executed only for its side-effects. */
> if (TREE_TYPE (val) == void_type_node)
> {
> ret = gimplify_expr (&TREE_OPERAND (*expr_p, 0), pre_p, post_p,
> is_gimple_stmt, fb_none);
> val = NULL;
> }
>
> which is used by Ada and should be described how.
The above is not Java or Ada specific but is just how SAVE_EXPR in GENERIC
works. It might be that other FEs never end up with SAVE_EXPRs around
"void" side-effects but I wouldn't bet on our testing coverage here.
So just remove the "such as SAVE_EXPRs generated by the Java frontend
for class initialization"
part of the comment.
> Ready for trunk?
Ok.
> Martin
