On 07/13/2017 03:26 AM, Christophe Lyon wrote: > I have executed a validation of your patch series on aarch64 and arm > targets, and I have minor comments. > > On arm, all new tests are unsupported, as expected. Good.
> On aarch64-linux, the new tests pass, but they fail on aarch64-elf: > - FAIL appears [ => FAIL]: That's really strange. I just tried that here and the only two failures I got were stack-check-7 and stack-check-8 which failed because I didn't have a cross assembler installed. > > > As I noticed that you used dg-require-effective-target > stack_clash_protected instead of > dg-require-stack-check "clash" that I recently committed, I also tried > with the later. Yea. Ultimately I decided that unless the target had explicitly added support for stack clash protection that the tests should be considered UNRESOLVED, even if the port had partial protection (as is the case with ARM). Thus I ended up with a new effective target test. I should have mentioned that in the cover letter. Thanks, Jeff
