No particular reason; I can merge it into one preprocessor line. -----Original Message----- From: drep...@gmail.com [mailto:drep...@gmail.com] On Behalf Of Ulrich Drepper Sent: Tuesday, July 18, 2017 12:24 AM To: Michael Collison <michael.colli...@arm.com> Cc: GCC Patches <gcc-patches@gcc.gnu.org>; nd <n...@arm.com> Subject: Re: PATCH v2][Aarch64] Add vectorized mersenne twister
On Tue, Jul 18, 2017 at 7:57 AM, Michael Collison <michael.colli...@arm.com> wrote: > This is the second version of a patch for Aarc64 to add a vectorized mersenne > twister to libstdc++. The first version used intrinsics and included > "arm_neon.h". After feedback from the community this version uses only GCC > vector extensions and Aarch64 simd data types. Looks OK. Just stylistically, why do you have +#ifdef __ARM_NEON +#ifdef __aarch64__ (in more than one place) instead of one preprocessor line?
