On Tue, 2017-07-11 at 15:19 -0600, Jeff Law wrote:

[...]

> diff --git a/gcc/opts.c b/gcc/opts.c
> index 7460c2b..61f5bb0 100644
> --- a/gcc/opts.c
> +++ b/gcc/opts.c
> @@ -2243,6 +2243,19 @@ common_handle_option (struct gcc_options
> *opts,
>         opts->x_flag_stack_check = STACK_CHECK_BUILTIN
>                            ? FULL_BUILTIN_STACK_CHECK
>                            : GENERIC_STACK_CHECK;
> +      else if (!strcmp (arg, "clash"))
> +       {
> +         /* This is the stack checking method, designed to prevent
> +            stack-clash attacks.  */
> +         if (!STACK_GROWS_DOWNWARD)
> +           sorry ("-fstack-check=clash not implemented on this
> target");

Minor nitpick: shouldn't options be quoted in diagnostics?

So this should be:

  sorry ("%<-fstack-check=clash%> not implemented on this target");

(or whatever it ends up being called)

[...]

Reply via email to