On Thu, Jul 06, 2017 at 09:41:00AM -0500, Steven Munroe wrote:
> + Net. Most MMX intrinsic operations can be performed efficiently as
> + C language 64-bit scalar operation or optimized to use the newer
> + 128-bit SSE/Altivec operations. */
I don't understand what "Net." is, maybe you can write it out?
> +typedef __attribute__ ((__aligned__ (8)))
> +union
> + {
> + __m64 as_m64;
> + char as_char [8];
> + signed char as_signed_char [8];
> + short as_short [4];
> + int as_int [2];
> + long long as_long_long;
> + float as_float [2];
> + double as_double;
> + }__m64_union;
Please add a space after "}" and remove those before "[".
> +/* Convert I to a __m64 object. The integer is zero-extended to
> 64-bits. */
> +extern __inline __m64 __attribute__((__gnu_inline__,
> __always_inline__, __artificial__))
> +_mm_cvtsi32_si64 (int __i)
> +{
> + return ((__m64)((unsigned int) __i));
> +}
No superfluous parentheses please, here and elsewhere. This is just
return (__m64) (unsigned int) __i;
(and the lines wrapped; misconfigured mail client?)
> +extern __inline __m64 __attribute__((__gnu_inline__,
> __always_inline__, __artificial__))
> +_mm_set_pi64x (long long __i)
> +{
> + return (__m64) __i;
> +}
> +/* Convert the __m64 object to a 64bit integer. */
Newline between the function and the following comment.
> +extern __inline long long __attribute__((__gnu_inline__,
> __always_inline__, __artificial__))
> +_mm_cvtm64_si64 (__m64 __i)
> +{
> + return (long long)__i;
> +}
Space after cast.
> +extern __inline __m64 __attribute__((__gnu_inline__, __always_inline__,
> __artificial__))
> +_mm_setzero_si64 (void)
> +{
> + return (__m64)0LL;
> +}
return (__m64) 0;
> + else
> + return (0);
else
return 0;
Okay for trunk, but please do something about the coding style stuff
(at least make things a bit more consistent). Thanks,
Segher
