Hi Carl,

On Wed, Jun 28, 2017 at 10:57:52AM -0700, Carl Love wrote:
> The vec_reve builtin test builtins-3-vec_reve-runnable did not have a
> minimum Power processor specified.  The thought was the instructions for
> the builtin were available on all the older processors.  Unfortunately,
> it turns out the builtin does require vsx hardware (-mvsx option).  Bill
> Schmidt said that the minimum platform that the builtins need to be
> supported on is Power 7.  The following patch sets the minimum platform
> as Power 7.
> 
> Please let me know if the following patch is acceptable.  Thanks.

Sure, that works.  Or just skip the testcase then (but we don't yet
have a convenient way to do that).  Okay for trunk (nit below).


>       2017-06-28  Carl Love  <c...@us.ibm.com>
> 
>       * gcc.target/powerpc/builtins-3-vec_reve-runnable.c (dg-options,
>       dg-skip-if): add mcpu=power7

Start with a capital, end with a dot.  The dg-skip-if is new...  Maybe
just lazily write

        * gcc.target/powerpc/builtins-3-vec_reve-runnable.c: Use -mvsx
        -mcpu=power7.

:-)

Thanks,


Segher

Reply via email to