On Thu, Jun 15, 2017 at 12:26 PM, Martin Sebor <mse...@gmail.com> wrote:
> On 06/12/2017 03:36 PM, Jason Merrill wrote:
>>
>> On 06/08/2017 01:25 PM, Martin Sebor wrote:
>>>
>>> + if (TREE_CHAIN (DECL_ARGUMENTS (f)))
>>> + {
>>> + /* Skip constructors that aren't copy or move ctors. */
>>> + if (!copy_fn_p (f))
>>> + continue;
>>> +
>>> + cpy_or_move_ctor_p = true;
>>> + }
>>> + else
>>> + {
>>> + /* Constructor is a default ctor. */
>>> + cpy_or_move_ctor_p = false;
>>> + }
>>
>> A default constructor can have parameters, so long as they have default
>> arguments. You can use default_ctor_p to test for a default constructor.
>
> Thank you for the suggestion. Attached is an incremental diff
> with this tweak plus a test for it.
>
> The code above has been there in the last three revisions of
> the patch
Yeah, I don't always notice everything :)
> are there any other changes you'd like me to make?
No, the patch is OK with this change.
Jason
