On 13 June 2017 at 10:31, Tamar Christina <tamar.christ...@arm.com> wrote: > Hi Christophe, > >> > gcc/testsuite/ >> > 2017-06-12 Tamar Christina <tamar.christ...@arm.com> >> > >> > * gcc.target/arm/sdiv_costs_1.c: Require arm_v8_vfp_ok. >> > >> >> I think you forgot to add a dg-add-options directive, to add -march=armv8-a >> or similar. > > Weird, is it still failing? When I tested it was skipping one configuration > and executing the rest. > > arm_v8_vfp_ok is supposed to add -mfpu=fp-armv8. When I tried it with > dg-add-options it didn't > work because it kept adding more options after the -march=armv8-a and > reverting it back to armv7. > dg-require-effective-target arm_v8_vfp_ok checks if there is a combination of options to enable the support for arm v8 vfp. In my log, I can see the arm_v8_vfp_ok sample code was compiled with -mfpu=fp-armv8 -mfloat-abi=softfp (on an arm-none-linux-gnueabi toolchain), but you still need to add dg-add-options, otherwise the testcase is compiled with -O3 only, (so *without* -mfpu=fp-armv8), and scan-assembler-times fail.
> The only way I found that seemed to work was skipping the test if not > supported. > > In principle all I really need to know is if the target has a hardware div, > but > check_effective_target_arm_divmod_simode did not seem to work. > >> >> Christophe >> >> > Thanks, >> > Tamar >> > ________________________________________ >> > From: gcc-patches-ow...@gcc.gnu.org <gcc-patches-ow...@gcc.gnu.org> >> on >> > behalf of Tamar Christina <tamar.christ...@arm.com> >> > Sent: Monday, June 12, 2017 1:35:08 PM >> > To: GCC Patches >> > Cc: nd; Kyrylo Tkachov; Richard Earnshaw; Ramana Radhakrishnan >> > Subject: [GCC][PATCH][ARM][Committed] Disable sdiv_1 test on softfloat >> targets. >> > >> > Hi All, >> > >> > I committed this as r249122 under the GCC obvious rule. >> > >> > This fixes the failing test gcc.target/arm/sdiv_costs_1.c on soft >> > float targets by disabling it on those targets since the div calls aren't >> expanded. >> > >> > gcc/testsuite/ >> > 2017-06-12 Tamar Christina <tamar.christ...@arm.com> >> > >> > * gcc.target/arm/sdiv_costs_1.c: Disable on softfloat. >> > >> > Thanks, >> > Tamar
