> Hi Honza & Christophe, > > I have tested your suggested fix. It does fix the regression. > Here is a simple patch for it. > > After r249013, die () and dump_stack () are both in cold section. This makes > the compiler generate bl instruction for the function call, instead of > honoring the -mlong-calls option. > > This patch changes the dump_stack function call conditional, which fixes the > regression. > > Okay to commit? > > Regards, > Renlin > > gcc/testsuite/ChangeLog: > > 2017-06-12 Renlin Li <renlin...@arm.com> > > * gcc.target/arm/cold-lc.c: Update coding style, call dump_stack > conditionally.
Looks OK to me. I think it does not change purpose of the testcase ;) Honza