On 05/27/2017 06:44 PM, Martin Sebor wrote:
+ /* True if the class is trivial and has a trivial non-deleted copy
+ assignment, copy ctor, and default ctor, respectively. The last
+ one isn't used to issue warnings but only to decide what suitable
+ alternatives to offer as replacements for the raw memory operation. */
+ bool trivial = trivial_type_p (desttype);
This comment seems out of date; there's only one variable here now.
+ /* True if the class is has a non-deleted trivial assignment. Set
s/is//
+ /* True if the class has a (possibly deleted) trivial copy ctor. */
+ bool trivcopy = trivially_copyable_p (desttype);
"True if the class is trivially copyable."
+ if (delassign)
+ warnfmt = G_("%qD writing to an object of type %#qT with "
+ "deleted copy assignment");
+ else if (!trivassign)
+ warnfmt = G_("%qD writing to an object of type %#qT with "
+ "no trivial copy assignment");
+ else if (!trivial)
+ warnfmt = G_("%qD writing to an object of non-trivial "
+ "type %#qT; use assignment instead");
I'd still like the !trivial test to come first in all the memset cases,
!trivcopy in the copy cases.
+static bool
+has_trivial_special_function (tree ctype, special_function_kind sfk,
+ bool *deleted_p)
This seems redundant with type_has_trivial_fn. If that function is
giving the wrong answer for a class where all of the SFK are deleted,
let's fix that, under check_bases_and_members, rather than introduce a
new function. I don't want to call synthesized_method_walk every time
we want to check whether a function is trivial.
Jason
