Hi Nathan,
> On 05/10/2017 05:05 AM, Richard Biener wrote:
>> On Tue, May 9, 2017 at 9:00 PM, Nathan Sidwell <nat...@acm.org> wrote:
>
>> +
>> +#define TDF_ADDRESS (1 << 3) /* dump node addresses */
>>
>> this leaves 1 << 2 unused.
>
> Yes, that was intentional (though I suspect my note about it was hidden).
> As you say, I expect further cleanup and didn't want gratuitous churn.
> I'll add a comment about bit 2 being free.
>
>> Otherwise looks like a great cleanup. You might want to coordinate with
>> Martin a bit here. It also looks like with this we can start re-using
>> bits when they are restricted to one TDF_KIND.
>
> Indeed, we coordinated a bit yesterday. Thanks for review!
it seems your patch caused
UNRESOLVED: g++.dg/inherit/covariant7.C -std=gnu++11 scan-tree-dump class "24
.*c6::_ZTcv0_n16_v0_n12_NV2c62f2Ev"
UNRESOLVED: g++.dg/inherit/covariant7.C -std=gnu++11 scan-tree-dump class "28
.*c6::f2"
UNRESOLVED: g++.dg/inherit/covariant7.C -std=gnu++11 scan-tree-dump class "80
.*0"
UNRESOLVED: g++.dg/inherit/covariant7.C -std=gnu++11 scan-tree-dump class "84
.*c6::_ZTv0_n16_NV2c62f2Ev"
UNRESOLVED: g++.dg/inherit/covariant7.C -std=gnu++14 scan-tree-dump class "24
.*c6::_ZTcv0_n16_v0_n12_NV2c62f2Ev"
UNRESOLVED: g++.dg/inherit/covariant7.C -std=gnu++14 scan-tree-dump class "28
.*c6::f2"
UNRESOLVED: g++.dg/inherit/covariant7.C -std=gnu++14 scan-tree-dump class "80
.*0"
UNRESOLVED: g++.dg/inherit/covariant7.C -std=gnu++14 scan-tree-dump class "84
.*c6::_ZTv0_n16_NV2c62f2Ev"
UNRESOLVED: g++.dg/inherit/covariant7.C -std=gnu++98 scan-tree-dump class "24
.*c6::_ZTcv0_n16_v0_n12_NV2c62f2Ev"
UNRESOLVED: g++.dg/inherit/covariant7.C -std=gnu++98 scan-tree-dump class "28
.*c6::f2"
UNRESOLVED: g++.dg/inherit/covariant7.C -std=gnu++98 scan-tree-dump class "80
.*0"
UNRESOLVED: g++.dg/inherit/covariant7.C -std=gnu++98 scan-tree-dump class "84
.*c6::_ZTv0_n16_NV2c62f2Ev"
On the gcc-7 branch, the dump file (from -fdump-class-hierarchy) was
called covariant7.C.002t.class, now it's covariant7.C.002l.class. But
gcc/testsuite/lib/scantree.exp (scan-tree-dump) expects the NNNt.<dump>
form.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
