On 02/05/17 18:08, Martin Jambor wrote:
Hi Andrew,
sorry for replying only now but yesterday was public holiday here and
I am still only in the process of recovering from a long weekend.
No problem, the UK had the same. :-)
While the only objection I have is the C++ style comment in
config/gcn/gcn.c, another problem, for me at least...
On Fri, Apr 28, 2017 at 06:06:39PM +0100, Andrew Stubbs wrote:
This patch, for the "gcn" branch, does three things:
1. Add specs to drive the LLVM assembler and linker. It requires them to be
installed as "as" and "ld", under $target/bin, but then the compiler Just
Works with these specs.
...is that I do not have llvm linker at hand and without it I did not
manage to make the patch produce loadable code. Because ROCm 1.5 has
been released today, I will update our environment, which is a bit
obsolete, get llvm ld and try again. This might take me a few days,
so please bear with me for a little more, I would like to make sure it
works on carrizos.
Understood. I do not have a carrizo to test on.
All my testing will be with FuryX Fiji discrete GPUs. The main
difference, from the software point of view, is that the shared memory
must be handled a little differently. (The existing HSA back-end appears
incompatible, as are the samples from the HSA Foundation sources; the
ROCm samples work fine.) However, the HSACO binary must encode the right
magic numbers or the driver rejects it, hence the need for this patch.
Andrew
