On 05/01/2017 04:23 PM, Nathan Sidwell wrote:
I happened to notice that stack adjustment code was confusingly testing for an unsigned value being > 0. In this case unadjusted_alignment is of type unsigned HOST_WIDE_INT, so the 'else' portion of the has no effect.

This patch simplifies the adjustment to be less confusing (IMHO).

booted and tested on x86_64-linux-gnu, ok?

OK I guess. It's not obvious what would happen with a wrong direction target, but the one we've got (PA) doesn't use this code because it's an ACCUMULATE_OUTGOING_ARGS target.

It appears that the size passed in would always be positive (it's a size after all), but I couldn't guarantee that without a lot more auditing.

Jeff

Reply via email to