Hi Segher, On Thu, 20 Apr 2017, Segher Boessenkool wrote: > + <li>There are new options <code>-mstack-protector-guard=global</code>, > + <code>-mstack-protector-guard=tls</code>, > + <code>-mstack-protector-guard-reg=</code>, and > + <code>-mstack-protector-guard-offset=</code>, to change how the stack > + protector gets the value to use as canary.</li>
no comma before "to change". And perhaps simply "New options...change how..."? The patch is fine if you consider this feedback. Well, one question: Don't these options do more than just changing how the value is obtained? The way I read the documentation the first two initiate generation of stack protection code? Am I confused, or should either the web patch or the documentation be adjusted? Gerald
