Hi!

On Tue, Apr 11, 2017 at 05:32:41PM -0400, Michael Meissner wrote:
> PR 80098 is an interaction between -mmodulo (ISA 3.0/power9 GPR modulo
> instructions) and -mno-vsx where the -mmodulo option enables some of the ISA
> 3.0 vector features, even though -mno-vsx was specified.
> 
> To do this, I added a table for disabling other vector options when the major
> vector options (-mvsx, -mpower8-vector, and -mpower9-vector) are disabled.
> 
> We could extend this if desired for other options (for example, -mno-popcntd
> could disable -mmodulo and perhaps the vector options).

Or we could just remove -mmodulo etc.  What good do they do?  They make
testing infeasible: an exponential number of combinations to test.

> @@ -3967,7 +3969,7 @@ rs6000_option_override_internal (bool gl
>  #endif
>  #ifdef OS_MISSING_ALTIVEC
>    if (OS_MISSING_ALTIVEC)
> -    set_masks &= ~(OPTION_MASK_ALTIVEC | OPTION_MASK_VSX);
> +    set_masks &= ~NO_ALTIVEC_MASKS;

NO_ALTIVEC_MASKS isn't defined anywhere.  Did you send the wrong patch?


Segher

Reply via email to