On Sun, Apr 02, 2017 at 12:24:16PM +0300, Ville Voutilainen wrote:
> On 2 April 2017 at 08:35, Jakub Jelinek <ja...@redhat.com> wrote:
> >> + remove_cv_t<_Tp>
> >> + )>
> >
> > Any reason for the wrapping?
>
> No, it's just a result of a nocturnal copy-paste-job of the existing
> code for has_unique_object_representations.
>
> > Also, shouldn't there be also:
> >
> > /// is_aggregate_v
> > template<typename _Tp>
> > _GLIBCXX17_INLINE constexpr bool is_aggregate_v =
> > is_aggregate<_Tp>::value;
> >
> > somewhere with appropriate guards (or within the same ones)?
>
> Yes, well spotted. I will add that.
>
> > I'm surprised tests for the is_*_v variable templates are only in
> > experimental/type_traits/value.cc when they are now apparently
> > part of C++17.
>
> Perhaps 20_util/variable_templates_for_traits.cc ?
Whatever you/Jonathan and/or Paolo agree on, libstdc++ isn't my area of
expertise.
Jakub
