Hi Carl,
On Mon, Jan 09, 2017 at 10:02:40AM -0800, Carl E. Love wrote:
> * config/rs6000/rs6000-c: Add support for built-in functions
rs6000-c.c
> vector signed char vec_nabs (vector signed char)
> vector signed short vec_nabs (vector signed short)
> vector signed int vec_nabs (vector signed int)
> vector signed long long vec_nabs (vector signed long long)
> vector float vec_nabs (vector float)
> vector double vec_nabs (vector double)
You should mention the name of the function or data etc. you modified here:
rs6000-c.c (altivec_overloaded_builtins): Blabla.
or something like that.
> * config/rs6000/rs6000-builtin.def: Add definitions for NABS functions
> and NABS overload.
> * config/rs6000/altivec.md: Add define to expand nabs<mode>2 types
> * config/rs6000/altivec.h: Add define for vec_nabs built-in function.
> * doc/extend.texi: Update the built-in documentation file for the
> new built-in functions.
Here, too.
> + int i, n_elt = GET_MODE_NUNITS (<MODE>mode);
Two lines for this please, two separate declarations. I realise you just
copied this code ;-)
Segher
