On Wed, Jan 11, 2017 at 09:41:42AM +0000, Kyrill Tkachov wrote: > > On 06/12/16 00:46, Michael Collison wrote: > >This patches fixes a regression in gcc.dg/zero_bits_compound-2.c. A recent > >patch (https://gcc.gnu.org/ml/gcc-patches/2016-11/msg02392.html) > >to the aarch64 backend improved generation for 'and' instructions with > >constants. The patch changed the number of 'and' instruction generated > > at the assembly level causing the test case to fail. This patch fixes the > > test case for aarch64 by verifies the 'and' insns at the rtl level instead > > at assembly time. > > > >A 'make check' was successfully completed aarch64-linux-gnu and > >x86_64-linux-gnu. > > > >Okay for trunk? > > Looks reasonable to me but since the changes are aarch64-specific, I think it > needs an approval from an aarch64 perspective.
OK. I think that's a bit pedantic for a testsuite change which is obvious (as this is, it just changes where we do the validation while maintaining the spirit of the test). Personally, I'd have applied it under the 'obvious' rule. Thanks, James
