Hi Andre, Thanks for doing this work with the instrumented compiler. It was a great help with PR78350.
As for the patch - OK for trunk. Paul On 11 December 2016 at 14:01, Andre Vehreschild <ve...@gmx.de> wrote: > Hi Mikael, hi Jerry, hi Steve, hi Jane, hi Thomas, hi Paul, hi all, > > thanks for all the input you gave on the patch I have present. I tried to > address all of it in the new version of the patch attached. > > Mikael: data.c::create_character_initializer() > I have remove the test for rvalue->value.character.string and went to > gfc_assign_data_value () line 483 to prevent calling the routine when rvalue > is > not an EXPR_CONSTANT (third chunk of the patch). > > interface.c::compare_actual_formal() > I have reverted the change to look at actual_arr_ref when looking for assumed > size arrays which are dummy argument arrays. That chunk (#5) is now only > additionally checking whether f.sym is really of type BT_CHARACTER before > accessing its ts.u.cl.lenght. > > For the second occurrence of actual_arr_ref I have extended > gfc_find_array_ref() with a flag to pass the search when no array ref is found > (Chunks #1, 2 and 6). > > Jerry: trans-expr.c::gfc_conv_cst_int_power() > I have added comment to new C++ code. Would you like to add something to it? > > The updated patch bootstraps and regtests fine on x86_64-linux/f23 on a > regular > and on an instrumented gfortran. How do you like this patch? > > Regards, > Andre > -- > Andre Vehreschild * Email: vehre ad gmx dot de -- If you're walking down the right path and you're willing to keep walking, eventually you'll make progress. Barack Obama
