On Fri, Nov 11, 2016 at 03:43:23PM -0800, Cesar Philippidis wrote:
> @@ -11801,12 +11807,11 @@ c_parser_oacc_shape_clause (c_parser *parser,
> omp_clause_code kind,
> }
>
> location_t expr_loc = c_parser_peek_token (parser)->location;
> - c_expr cexpr = c_parser_expr_no_commas (parser, NULL);
> - cexpr = convert_lvalue_to_rvalue (expr_loc, cexpr, false, true);
> - tree expr = cexpr.value;
> + tree expr = c_parser_expr_no_commas (parser, NULL).value;
> if (expr == error_mark_node)
> goto cleanup_error;
>
> + mark_exp_read (expr);
> expr = c_fully_fold (expr, false, NULL);
>
> /* Attempt to statically determine when the number isn't a
Why? Are the arguments of the clauses lvalues?
> @@ -11867,12 +11872,12 @@ c_parser_oacc_shape_clause (c_parser *parser,
> omp_clause_code kind,
> seq */
>
> static tree
> -c_parser_oacc_simple_clause (c_parser *parser, enum omp_clause_code code,
> - tree list)
> +c_parser_oacc_simple_clause (c_parser * /* parser */, location_t loc,
Just leave it as c_parser *, or better yet remove the argument if you don't
need it.
> + else
> + {
> + //TODO? TREE_USED (decl) = 1;
This would be /* FIXME: TREE_USED (decl) = 1; */
but wouldn't it be better to figure out if you want to do that or not?
Jakub
