Hi!
On Thu, Nov 17, 2016 at 05:31:40PM +0800, Chung-Lin Tang wrote:
> +#ifndef ACCEL_COMPILER
> + span = integer_one_node;
> +#else
> + if (!e_mask)
> + /* Not paritioning. */
> + span = integer_one_node;
...
This goes against the recent trend of avoiding #if/#ifdef guarded blocks
of code as much as possible, the ACCEL_COMPILER only hunk is significant
and will usually not be enabled, so people will not notice breakages in it
until building an accel compiler.
What about
#ifndef ACCEL_COMPILER
if (true)
span = integer_one_node;
else
#endif
if (!e_mask)
/* Not paritioning. */
span_integer_one_node;
else if
...
or what I've proposed earlier:
#ifndef ACCEL_COMPILER
e_mask = 0;
#endif
if (!e_mask)
...
Ok with that fixed.
Jakub
