On Tue, Nov 15, 2016 at 12:33:06PM +0000, Richard Sandiford wrote: > The transformations made by make_compound_operation apply > only to scalar integer modes. The fix for PR70944 had enforced > that by returning early for vector modes at the top of the > function. However, the function is supposed to be recursive, > so we should continue to look at integer suboperands even if > the outer operation is a vector one. > > This patch instead splits out the non-recursive parts > of make_compound_operation into a subroutine and checks > that the mode is a scalar integer before calling it. > The patch was originally written to help with the later > conversion to static type checking of mode classes, but it > also happened to reenable optimisation of things like > vec_duplicate operands. > > Note that the gen_lowparts in the PLUS and MINUS cases > were redundant, since new_rtx already had mode "mode" > at those points. > > Tested on aarch64-linux-gnu and x86_64-linux-gnu. OK to install?
Yes, please do. You can use maybe_swap_commutative_operands in change_zero_ext as well, perhaps in more places, do you want to take a look? Thanks, Segher
