Hi Mike, > On Nov 14, 2016, at 8:59 AM, Iain Sandoe <i...@codesourcery.com> wrote: >> >>> On 14 Nov 2016, at 16:57, Jack Howarth <howarth.at....@gmail.com> wrote: >>> >>> The attached patch fixes PR sanitizer/78267 by conditionalizing the >>> include of <os/trace.h> on the compiler defining __BLOCKS__ as a >>> supported extension. Passes bootstrap on x86_64-apple-darwin15. Okay >>> for gcc trunk? >>> <PR78267.diff> >> >> Rainer has that PR assigned and is making a proper fix (which will >> prevent other failures on the port), unless he decides to punt on it, I >> think we should wait and get a proper fix, > > I'm fine with waiting if Jack wants, but the danger is leaving things in a > non-working state for too long, and things can pile up. I'd rather put in > the fix to the build, now, and, if technology advances to allow that code > to be removed later, it always can be. If people are to wait, it is better > to know how long to wait. A week, a month, a year? Then, when that time > passes, they know to ask again. How long should we wait?
my patch has been verified to work on 10.12. The revised patch has been developed with a copy of the affected 10.11 headers, but needs to be tested on the real thing. Iain has provided me with the affected 10.10 headers and I expect to have an augmented patch ready today or tomorrow. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University