On Fri, Sep 9, 2011 at 12:00 PM, Terry Guo <terry....@arm.com> wrote:
> Hello,
>
> This patch enables the case pass on targets other than armv7-a by skipping
> the architecture conflict message. Is it OK to trunk?

I don't like these kind of patches.  Why do the testcases have -march=armv7-a
enabled in the first place?  If they really need it then they shouldn't be
run with another -march and thus instead there should be a
dg-requires-effective-target armv7-a.  If they don't really need it
they shouldn't
add it.

Richard.

> BR,
> Terry
>
> 2011-09-09  Terry Guo  <terry....@arm.com>
>
>          * gcc.target/arm/neon-thumb2-move.c: Skip the
>        architecture conflict to enable the case pass
>        on targets other than armv7-a.
>
> diff --git a/gcc/testsuite/gcc.target/arm/neon-thumb2-move.c
> b/gcc/testsuite/gcc.target/arm/neon-thumb2-move.c
> index 430a4d5..9cf86dd 100644
> --- a/gcc/testsuite/gcc.target/arm/neon-thumb2-move.c
> +++ b/gcc/testsuite/gcc.target/arm/neon-thumb2-move.c
> @@ -3,6 +3,7 @@
>  /* { dg-require-effective-target arm_thumb2_ok } */
>  /* { dg-options "-O2 -mthumb -march=armv7-a" } */
>  /* { dg-add-options arm_neon } */
> +/* { dg-prune-output "switch .* conflicts with" } */
>
>  #include <arm_neon.h>
>  #include <stddef.h>
>
>
>
>
>
>

Reply via email to