On 7 November 2016 at 14:55, Tamar Christina <tamar.christ...@arm.com> wrote: > Hi all, > > This patch (3 of 3) adds updates tests for the NEON intrinsics > added by the previous patches: > > Ran regression tests on aarch64-none-linux-gnu > and on arm-none-linux-gnueabihf. > > Ok for trunk? > > Thanks, > Tamar > > > gcc/testsuite/ > 2016-11-04 Tamar Christina <tamar.christ...@arm.com> > > * gcc.target/aarch64/advsimd-intrinsics/p64.c: New. > * gcc.target/aarch64/advsimd-intrinsics/arm-neon-ref.h > (Poly64x1_t, Poly64x2_t): Added type. > (AARCH64_ONLY): Added macro. > * gcc.target/aarch64/advsimd-intrinsics/vcombine.c: > Added test for Poly64. > * gcc.target/aarch64/advsimd-intrinsics/vcreate.c: Likewise. > * gcc.target/aarch64/advsimd-intrinsics/vdup-vmov.c: Likewise. > * gcc.target/aarch64/advsimd-intrinsics/vdup_lane.c: Likewise. > * gcc.target/aarch64/advsimd-intrinsics/vget_high.c: Likewise. > * gcc.target/aarch64/advsimd-intrinsics/vget_lane.c: Likewise. > * gcc.target/aarch64/advsimd-intrinsics/vget_low.c: Likewise. > * gcc.target/aarch64/advsimd-intrinsics/vldX.c: Likewise. > * gcc.target/aarch64/advsimd-intrinsics/vldX_dup.c: Likewise. > * gcc.target/aarch64/advsimd-intrinsics/vldX_lane.c: Likewise. > * gcc.target/aarch64/advsimd-intrinsics/vstX_lane.c: Likewise. > * gcc.target/aarch64/advsimd-intrinsics/vst1_lane.c: Likewise. > * gcc.target/aarch64/advsimd-intrinsics/vld1.c: Likewise. > * gcc.target/aarch64/advsimd-intrinsics/vreinterpret_p128.c: > Added AArch64 flags. > * gcc.target/aarch64/advsimd-intrinsics/vreinterpret_p64.c: > Added Aarch64 flags.
Hi Tamar, A while ago I added p64_p128.c, to contain all the poly64/128 tests except for vreinterpret. Why do you need to create p64.c ? Similarly, adding tests for vcreate_p64 etc... in p64.c or p64_p128.c might be easier to maintain than adding them to vcreate.c etc with several #ifdef conditions. For vdup-vmod.c, why do you add the "&& defined(__aarch64__)" condition? These intrinsics are defined in arm/arm_neon.h, right? They are tested in p64_p128.c Looking at your patch, it seems some tests are currently missing for arm: vget_high_p64. I'm not sure why I missed it when I removed neont-testgen... Regarding vreinterpret_p128.c, doesn't the existing effective-target arm_crypto_ok prevent the tests from running on aarch64? Thanks, Christophe
