On 2 November 2016 at 18:29, Jason Merrill <ja...@redhat.com> wrote:
> Then I'll approve the whole patch.
Thanks!
Trying the patch on kernel build (allmodconfig) reveals the following
couple of warnings:
http://pastebin.com/Sv2HFDUv
I think warning for str_error_r() is correct, however I am not sure if
warning for
pager_preexec() is legit or a false positive:
pager.c: In function 'pager_preexec':
pager.c:35:12: warning: passing argument 2 to restrict-qualified
parameter aliases with argument 4 [-Wrestrict]
select(1, &in, NULL, &in, NULL);
^~~ ~~~
Is the warning correct for the above call to select() syscall ?
I am a bit anxious about keeping the warning in Wall because it's
breaking the kernel.
Should we instead keep it in Wextra, or continue keeping it in Wall ?
Also is there a way to gracefully disable Werror for kernel builds ?
I tried:
make allmodconfig
make all KCFLAGS="-Wno-error=restrict" CFLAGS="-Wno-error=restrict" -j8
but that didn't work. I managed to workaround by manually modifying
Makefiles to not pass Werror,
but I hope there's a better way.
Thanks,
Prathamesh
>
> On Wed, Nov 2, 2016 at 8:42 AM, Joseph Myers <jos...@codesourcery.com> wrote:
>> The format-checking parts of the patch are OK.
>>
>> --
>> Joseph S. Myers
>> jos...@codesourcery.com
