On Wed, Oct 05, 2016 at 06:52:55PM +0200, Marek Polacek wrote:
> Ping.
>
> On Thu, Sep 29, 2016 at 06:10:27PM +0200, Marek Polacek wrote:
> > Here, a missing -Wimplicit-fallthrough warning was caused by a misplaced
> > FALLTHROUGH_LABEL_P check. As it is now, for FALLTHROUGH_LABEL_P we'd
> > never gotten around to
> > 1933 /* So that next warn_implicit_fallthrough_r will start
> > looking for
> > 1934 a new sequence starting with this label. */
> > 1935 gsi_prev (gsi_p);
> >
> > The fix is to move the check to should_warn_for_implicit_fallthrough.
> >
> > Bootstrapped/regtested on x86_64-linux and ppc64-linux, ok for trunk?
> >
> > 2016-09-29 Marek Polacek <pola...@redhat.com>
> >
> > * gimplify.c (should_warn_for_implicit_fallthrough): Check for
> > FALLTHROUGH_LABEL_P here...
> > (warn_implicit_fallthrough_r): ...not here.
> >
> > * c-c++-common/Wimplicit-fallthrough-22.c: New test.
Ok, thanks.
Jakub
