On Tue, Oct 04, 2016 at 05:58:17PM +0200, Michael Matz wrote:
> Hi,
>
> On Sat, 1 Oct 2016, Jakub Jelinek wrote:
>
> > > - /* ... fall through for unsigned ints ... */
> > > + /* fall through */
> > >
> > > - /* For other instructions, fallthru. */
> > > + /* fallthru. */
> > >
> > > - /* fall thru to manual case */
> > > + /* fall thru */
> > >
> > >
> > > So, because of its excessive pickiness, the warning ends up making the
> > > user
> > > butcher informative comments. How is that helpful?
> >
> > Note, the wast majority of the fallthru comments are already recognized, it
> > is only when people start to write those in free form.
>
> Which is what happens often. How can you not see that with patches
> transforming from free form to strict form fly by _on this very mailing
> list_ ?
I think the vast majority of the comments I changed (removing "...") wouldn't
have to be changed were this patch in. But it didn't hurt, either.
Marek
