On Tue, Sep 27, 2016 at 03:09:36PM +0200, Richard Biener wrote:
> On Tue, Sep 27, 2016 at 3:05 PM, Marek Polacek <pola...@redhat.com> wrote:
> > Using -Wno-error where only -Wno-implicit-fallthrough was meant was deemed
> > to coarse, so this patch attempts to add a configure check for this warnign
> > and only use -Wno-implicit-fallthrough when appropriate.
> >
> > Bootstrapped on x86_64-linux and ppc64-linux, ok for trunk?
>
> It looks to me this would hide eventual bugs in .md files by not
> issueing the warning?
Guess it depends on what kind of warnings we want to suppress here, if it is
something user can control in their *.md files, or something that perhaps
changes to the generators could handle (add /* FALLTHRU */ comments or
gcc_fallthrough (); in some cases)?
> > 2016-09-27 Marek Polacek <pola...@redhat.com>
> >
> > * Makefile.in (insn-attrtab.o-warn, insn-dfatab.o-warn,
> > insn-latencytab.o-warn, insn-output.o-warn, insn-emit.o-warn): Use
> > @W_NO_IMPLICIT_FALLTHROUGH@ instead of -Wno-error.
> > * configure.ac: Add check for -Wimplicit-fallthrough.
> > * configure: Regenerate.
Jakub
