On 09/27/16 08:46, Martin Liška wrote:

Second version of the patch adds validation to gcov.exp, where $result is scanned for 
"File '<built-in>'".
Luckily current test-case hit that verification:

FAIL: gcc.misc-tests/gcov-6.c gcov failed: <built-in>.gcov should not be created
FAIL: gcc.misc-tests/gcov-7.c gcov failed: <built-in>.gcov should not be created

thanks.

One thing I dislike is negated predicates though -- I think I'd find
   if (!gimple_has_reserved_location (gs))
to be more understandable (particularly as that matches the sense of 
RESERVED_LOCATION_P.

Agree with you, renamed to gimple_has_reserved_location.
Ready with that change?

Adding missing patch.

I think this needs Richard's approval for the gimple predicates etc.  But OK 
for me.

nathan

Reply via email to