On Mon, Sep 26, 2016 at 03:34:40PM +0200, Rainer Orth wrote:
> Hi Marek,
>
> > All right. I'll commit the patch on Monday.
>
> this patch caused quite some breakage: Ada, Solaris/x86 and SPARC don't
> bootstrap any longer.
Sorry about that. I had tested Ada + x86_64/ppc64/aarch64, but couldn't
test neither Solaris nor SPARC.
> The following patch allows i386-pc-solaris2.12 and sparc-sun-solaris2.12
> bootstraps continue.
>
> Strangely, I needed to use gcc_fallthrough () in i386.c; a mere /* FALLTHRU */
> had no effect.
Yes, this is expected. /* FALLTHRU */ comments only work if the next token
is a case label or default label.
> Ok for mainline if the bootstraps pass (with appropriate changelog
> entries, of course)?
LGTM, though I can't approve.
Thanks a lot.
Marek
