On Fri, 2016-09-09 at 16:56 -0600, Jeff Law wrote: > On 08/24/2016 07:13 PM, David Malcolm wrote: > > Here's a much less ambitious version of the patch kit, which > > eliminates any attempt to write to the user's source > > code (getting rid of edit_context::apply_changes and > > -fdiagnostics-apply-fixits). > > > > It implements -fdiagnostics-generate-patch. In so doing, it > > tightens up the exact semantics of fix-its; see [1] for an > > example of where that's useful. > > > > I need review of at least patches 1 and 2 (which are unchanged > > from v1 of the kit). I believe I can self-approve patches 3 > > and 4 as part of my "diagnostics maintainer" role; are they > > acceptable to those who objected to the earlier kit? (now > > that there's no attempt to write to source files). > > > > Successfully bootstrapped®rtested the combination of the patches > > on x86_64-pc-linux-gnu. > > > > OK for trunk? (assuming individual bootstraps®rtesting) > > > > [1] https://gcc.gnu.org/ml/gcc-patches/2016-08/msg01751.html > My understanding was #1 was approved by Bernd. I think the update to > #1 > which removes the unnecessary explicit namespaces is fine.
Thanks (Bernd also approved it as https://gcc.gnu.org/ml/gcc-patches/2016-08/msg02109.html ; I committed it as r239892. > Have you addressed the question/concern for #2? > > https://gcc.gnu.org/ml/gcc-patches/2016-08/msg02125.html Yes, in: https://gcc.gnu.org/ml/gcc-patches/2016-09/msg00001.html which Bernd approved in: https://gcc.gnu.org/ml/gcc-patches/2016-09/msg00023.html I committed it as r239958. FWIW I've already committed the rest of the less-ambitious patch kit: - patch 3 (edit_context) as r239963, and - patch 4 (-fdiagnostics-generate-patch) as r239965 I'm experimenting with using edit_context to provide more readable printing of fix-it hints in diagnostic-show-locus.c, and with the support needed to add "break;\n" etc fix-its for -Wfallthrough (i.e. how to cope with newlines and indentation). Dave
