On 09/08/2016 12:09 PM, Thomas Schwinge wrote:
Hi!
A few review comments:
On Wed, 7 Sep 2016 20:19:20 +0300, Andris Pavenis <andris.pave...@iki.fi> wrote:
This patch fixes handling header.gcc in subdirectories when command line option
-remap has been
used.
(I have not yet reviewed the logic of your change itself.) Wouldn't it
be simpler to just unconditionally add a directory separator here?
Is it OK to assume that a directory separator always is "/"? (Think DOS,
Windows etc. But maybe there's some "translation layer" beneath this --
I don't know.)
No.
DJGPP supports both '/' and '\'. '\' is OK except in some cases (special handling of paths
beginning with /dev/). Blind conversion off all '/' to '\' do not work for DJGPP due to this reason
(had related problems in directory gcc/ada).
Windows targets (WINGW, Cygwin): at least in Ada gcc/ada/s-os_lib.adb converts all '/' to '\' for
Windows targets and without submitted but not yet committed patch also for DJGPP (that broke
bootstrapping gcc for DJGPP due to gnatmake not working). I have not done however real testing for
Windows targets myself.
Can you provide some test cases? (Ah, I now see you got some "Test
script to reproduce problem" attached to <https://gcc.gnu.org/PR71681> --
this should be turned into a regression test for the GCC testsuite.)
Which could more appropriate place for test-case?
- gcc/testsuite/c-c++-common/cpp
- gcc/testsuite/gcc.dg/cpp
Also should this test be in a separate subdirectory under either of them?
It is good practice to assign a GCC PR to yourself if you're working on
it, and it also helps to post to the PR a comment with a link to the
mailing list archive for patch submissions, etc.
Done
Andris
