On Tue, Aug 23, 2016 at 12:58 PM, Dominik Vogt <v...@linux.vnet.ibm.com> wrote: > On Tue, Aug 23, 2016 at 11:57:01AM -0700, Ian Lance Taylor wrote: >> The root cause of https://golang.org/issue/16780 is that GCC on s390 >> GNU/Linux does not emit a .file directive. This is because the >> function s390_asm_file_start does not call default_file_start, unlike >> most other TARGET_ASM_FILE_START hooks. This patch should fix the >> problem. Since I don't have an s390 handy, it would be great if >> somebody could test this for me. Thanks. > > I've run a regression test "light" with the patch, i.e. only s390x > and Gcc only built with the C language, and it works fine except > that one test case fails that because a "scan-assembler-not" now > matches the ".file" line at the beginning of the file. See > attached patch with that change added. > > Additional ChangeLog for the test: > > gcc/testsuite/ChangeLog > > * gcc.target/s390/nolrl-1.c: Don't match the filename.
Thanks. Committed to mainline. Ian