On Thu, Aug 04, 2016 at 09:27:55AM -0600, Kelvin Nilsen wrote:
> The patch has been bootstrapped and tested on powerpc64le-unknown-linux
> and on powerpc64-unknown-linux (big-endian) with no regressions. Is
> this ok for the trunk?
Just a couple more nits.. Okay for trunk with those fixed / looked at.
> --- gcc/config/rs6000/rs6000-c.c (revision 238014)
> +++ gcc/config/rs6000/rs6000-c.c (working copy)
> @@ -4302,6 +4302,84 @@ const struct altivec_builtin_types altivec_overloa
> RS6000_BTI_unsigned_V4SI, RS6000_BTI_unsigned_V4SI,
> RS6000_BTI_unsigned_V4SI, 0 },
>
> + { P9V_BUILTIN_VEC_VES, P9V_BUILTIN_VESSP,
> + RS6000_BTI_V4SI, RS6000_BTI_V4SF, 0, 0 },
There are still trailing spaces here.
> +(define_expand "xscmpexpdp_<code>"
> + [(set (match_dup 3)
> + (compare:CCFP
> + (unspec:DF
> + [(match_operand:DF 1 "vsx_register_operand" "wa")
> + (match_operand:DF 2 "vsx_register_operand" "wa")]
> + UNSPEC_VSX_SCMPEXPDP)
> + (match_dup 4)))
> + (set (match_operand:SI 0 "register_operand" "=r")
> + (CMP_TEST:SI (match_dup 3)
> + (const_int 0)))]
> + "TARGET_P9_VECTOR"
> +{
> + operands[3] = gen_reg_rtx (CCFPmode);
> + operands[4] = CONST0_RTX (SImode);
> +})
"CONST0_RTX (SImode)" is just "const0_rtx". You can write it in the
pattern I think? As "(const_int 0)"?
> +# Exit immediately if this isn't a PowerPC target.
> +if { ![istarget powerpc*-*-*] && ![istarget rs6000-*-*] } then {
> + return
> +}
I would put the AIX test here, too.
Thanks,
Segher
