On Thu, Jun 23, 2016 at 09:32:13PM -0500, Bill Schmidt wrote:
> (I've had some possible mailer problems with previous patches, so
> I will try both inserting the patch and providing an attachment.  Please
> let me know which (if either) is preferable.)

Both are quoted-printable, which is just awful.  The attachment is worse.

> Index: gcc/config/rs6000/rs6000-builtin.def
> ===================================================================
> --- gcc/config/rs6000/rs6000-builtin.def      (revision 237619)
> +++ gcc/config/rs6000/rs6000-builtin.def      (working copy)
> @@ -652,7 +652,23 @@
>                    | RS6000_BTC_BINARY),                              \
>                   CODE_FOR_ ## ICODE)                 /* ICODE */
>  
> +/* IEEE 128-bit floating-point builtins.  */
> +#define BU_FLOAT128_2(ENUM, NAME, ATTR, ICODE)                          \
> +  RS6000_BUILTIN_2 (MISC_BUILTIN_ ## ENUM,              /* ENUM */      \
> +                    "__builtin_" NAME,                  /* NAME */      \

This last line still is indented with spaces.  Similar elsewhere.  But
looking at the original file, it is a mess as well, so I'll ignore this
file.

> @@ -35569,6 +35639,7 @@ static struct rs6000_opt_mask const rs6000_builtin
>    { "hard-dfp",               RS6000_BTM_DFP,        false, false },
>    { "hard-float",     RS6000_BTM_HARD_FLOAT, false, false },
>    { "long-double-128",        RS6000_BTM_LDBL128,    false, false },
> +  { "float128",               RS6000_BTM_FLOAT128,   false, false },

Still has spaces instead of a tab before that "false, false".

> @@ -2705,7 +2706,8 @@ extern int frame_pointer_needed;
>                                | RS6000_BTM_CELL                      \
>                                | RS6000_BTM_DFP                       \
>                                | RS6000_BTM_HARD_FLOAT                \
> -                              | RS6000_BTM_LDBL128)
> +                              | RS6000_BTM_LDBL128                   \
> +                              | RS6000_BTM_FLOAT128)

Same here, before the "\".

The user documentation should probably say Altivec instead of VMX, to
reduce confusion.

Okay for trunk with those fixes.  Thanks!

Please see if the existing float128 tests are usable for us before
doing a backport.


Segher

Reply via email to