On 06/20/2016 10:17 PM, Martin Sebor wrote:
+      && tree_int_cst_equal (lhs, null_pointer_node)
+      && !tree_int_cst_equal (rhs, integer_zero_node))

Not integer_zerop?

+                           "invalid conversion involving a null pointer");
...
+                           "invalid conversion from %qT to %qT",

The conversion isn't invalid, it just isn't a constant expression. For the null pointer to pointer conversion, does this properly allow conversion to void* or to base*?

+           if (integer_zerop (op))
...
+         else if (!integer_zerop (op))

The second test seems redundant.

Jason

Reply via email to