On Thu, Aug 25, 2011 at 18:14, Gabriel Charette <gch...@google.com> wrote: > This was the last thing remaining on my cleanup list. > > As suggested by Steven and Jason in issue4550121, we should use > REAL_IDENTIFIER_TYPE_VALUE for IDENTIFIER_NODEs instead of TREE_TYPE > (although the former resolves to the later in its macro definition, this is > more robust to potential later changes to TREE_TYPE in trunk). > This patch does that change. > > As mentionned by Steven in the same issue, we were accessing some fields > directly instead of correctly using their corresponding accessor macros. > This patch makes use of the correct accessor macros for > pph_read/write_tree_body.
Nice! Thanks for this cleanup. > 2011-08-25 Gabriel Charette <gch...@google.com> > > * pph-streamer-in.c (pph_read_tree_body): Use accessor macros for > all fields. Use REAL_IDENTIFIER_TYPE_VALUE instead of TREE_TYPE > for the IDENTIFIER_NODE case. > * pph-streamer-out.c (pph_write_tree_body): Likewise. OK. Diego.
