Hi! On Wed, 8 Jun 2016 16:08:38 +0200, Jakub Jelinek <ja...@redhat.com> wrote: > On Wed, Jun 08, 2016 at 03:27:44PM +0200, Thomas Schwinge wrote: > > This got me confused recently, so I took the effort to clean it up. OK > > to commit? > > As I said earlier, I don't find anything confusing on what we have there > and would strongly prefer not to change it.
Please explain why you are rejecting clean-up patches that make the code (variable names) actually match its semantics, make it easy for the reader? > Can you submit the actual testsuite change which got hidden in all the > renaming separately? > > Thanks. I submitted that more than a month ago, and pinged it thrice, <http://news.gmane.org/find-root.php?message_id=%3C871t4qu15e.fsf%40hertz.schwinge.homeip.net%3E>. As you can see, there actually is a difference between offload_plugins and offload_targets (for example, "intelmic" vs. "x86_64-intelmicemul-linux-gnu"), and I'm using both variables -- to avoid having to translate the more specific "x86_64-intelmicemul-linux-gnu" (which we required in the test harness) into the less specific "intelmic" (for plugin loading) in libgomp/target.c. I can do that, so that we can continue to use just a single offload_targets variable, but I consider that a less elegant solution. Grüße Thomas
