On Wed, 24 Aug 2011 17:04:55 +0100 Julian Brown <jul...@codesourcery.com> wrote:
> On Sun, 07 Aug 2011 18:47:57 +0100 > Richard Sandiford <rdsandif...@googlemail.com> wrote: > > > This patch caused several regressions on big-endian 64-bit MIPS > > targets, which now try to shift single-precision floating-point > > arguments to the top of an FPR. [...] > > Sorry for the breakage! > > > The patch below borrows the padding code from the main call > > routines. It fixes the MIPS problems for me (tested on > > mips64-linux-gnu), but I'm not set up for big-endian ARM testing. > > From what I can tell, other targets' BLOCK_REG_PADDING definitions > > already handle null types. > > I tested your patch very lightly on ARM, by running arm.exp & > fixed-point.exp in both big & little-endian mode, and it looks fine. > I'll set off a more-complete test run also, in case that's helpful... The patch looks fine for big/little endian, gcc/g++/libstdc++, cross to ARM EABI, btw. Cheers, Julian