Hi,

On 30/05/2016 18:07, Jason Merrill wrote:
On 05/30/2016 11:42 AM, Paolo Carlini wrote:
+unqualified_name_lookup_error (tree name, location_t loc)
 {
+  if (loc == UNKNOWN_LOCATION)
+    loc = location_of (name);

When does this do anything useful? If name is a DECL, this will give the wrong answer. If name is an IDENTIFIER_NODE, this will give UNKNOWN_LOCATION.
Indeed, I wasn't sure, as I said, I tried to be conservative, because we used to call in that function. I'm going to regression test again with input_location instead. Does the patch otherwise looks sane?

Thanks,
Paolo.

Reply via email to