On Fri, May 27, 2016 at 02:01:33PM -0600, Kelvin Nilsen wrote:
> 
> This patch adds built-in function support for the Power9 vslv and vsrv
> instructions.


> +Tne @code{vec_slv} and @code{vec_srv} functions operate in parallel on

Typo ("Tne").

> +all of the bytes of their @code{src} and @code{shift_distance}
> +arguments in parallel.  The behavior of the @code{vec_slv} is as if

You also say "in parallel" twice here.

> --- gcc/testsuite/gcc.target/powerpc/vslv-0.c (revision 0)
> +++ gcc/testsuite/gcc.target/powerpc/vslv-0.c (working copy)
> @@ -0,0 +1,14 @@
> +/* { dg-do compile { target { powerpc*-*-* } } } */
> +/* { dg-options "-mcpu=power9" } */

I think you need to prevent the user from overriding -mcpu= for these
tests?  There are many examples of this in gcc.target/powerpc/ .

Okay for trunk with those things taken care of; okay for 6 later, too.

Thanks,


Segher

Reply via email to