On 05/18/16 20:03, Jim Wilson wrote:
Though I see that the original patch from Samsung that added the max_case_values field has the -O3 check, so there was apparently some reason why they wanted it to work that way. The value that the exynos-m1 is using, 48, looks pretty large, so maybe they thought that the code size expansion from that is only OK at -O3 and above. Worst case, we might need two max_case_value fields, one to use at -O1/-O2, and one to use at -O3. Jim
Indeed, the reason to restrict the new limit to -O3 in my original patch was the increased cost in code size.
I'm fine with this patch, as it achieves in part what I intended before: going beyond the default_case_values_threshold, too conservative for Exynos M1. My concern is particularly what happens to in-order targets, like the ubiquitous A53.
I'll get make some figures available soon. Cheers, -- Evandro Menezes
