On 18 May 2016 at 11:44, Jiong Wang <jiong.w...@foss.arm.com> wrote: > > > On 18/05/16 09:25, Christophe Lyon wrote: >> >> >> Unfortunately, the guard is not correct :( >> >> The float64_t type is not available on arm, so the new >> declarations/definitions in arm-neon-ref.h >> need a guard. >> >> Since this patch was checked-in, all the advsimd intrinsics tests fail >> to compile >> on arm: >> In file included from >> >> /aci-gcc-fsf/sources/gcc-fsf/gccsrc/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vaba.c:2:0: >> >> /aci-gcc-fsf/sources/gcc-fsf/gccsrc/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/arm-neon-ref.h:139:22: >> error: unknown type name 'float64_t' >> >> /aci-gcc-fsf/sources/gcc-fsf/gccsrc/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/arm-neon-ref.h:51:35: >> note: in definition of macro 'VECT_VAR_DECL' >> >> /aci-gcc-fsf/sources/gcc-fsf/gccsrc/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/arm-neon-ref.h:139:8: >> note: in expansion of macro 'ARRAY' >> >> > > Hi Christophe > > sorry for the breakage. > I have run aarch64 regression before commit, I will keep in mind to run arm > also next time as this directory is shared. > > I committed the following fix, r236370, as obivious after retest of > advsimd-intrinsics.exp > for both aarch64 and arm OK. > > gcc/testsuite/ > > 2016-05-18 Jiong Wang <jiong.w...@arm.com> > > * gcc.target/aarch64/advsimd-intrinsics/arm-neon-ref.h: Guard > float64_t > with __aarch64__. > * gcc.target/aarch64/advsimd-intrinsics/vfms_vfma_n.c: Guard > variable > declaration under __aarch64__ and __ARM_FEATURE_FMA. >
Cool, thanks. I was running the tests with the same patch before committing too :) Christophe.
