On 05/06/2016 09:19 AM, Jakub Jelinek wrote:
On Fri, May 06, 2016 at 11:11:29PM +0800, Marcel Böhme wrote:
+ dpi.copy_templates
+ = (struct d_print_template *) malloc (((size_t) dpi.num_copy_templates)
+ * sizeof (*dpi.copy_templates));
+ if (! dpi.copy_templates)
+ {
+ d_print_error (&dpi);
+ return 0;
+ }
Another thing to consider is if the common values of dpi.num_*
and similarly in the other block are small enough, it might be desirable
to just use an automatic fixed size array (or even alloca) and only
fall back to malloc if it is too large.
Please, no, don't fall back to alloca like this. That coding idiom has
been the source of numerous security exploits in glibc. Experience
shows us that we are not capable of doing that correctly on a consistent
basis.
Jeff
