On Wed, 9 Mar 2016, Nathan Sidwell wrote: > On 03/09/16 09:55, Alexander Monakov wrote: > > The preceding code special-casing response to -gstabs can also be removed > > after this patch. Should I submit the (trivial) removal patch? > > No. I found that necessary to stop the testsuite testing stabs -- it expects > an error, but we don't get one without that check.
Since you removed the unnecessary override, the specific check is no longer necessary: toplevel code is capable of issuing the error for unsupported debug info format like this: :|x86_64-pc-linux-gnu-accel-nvptx-none-gcc -xc - -S -o- -gstabs <stdin>:1:0: sorry, unimplemented: stabs debug format not supported cc1: error: target system does not support the ‘stabs’ debug format :|x86_64-pc-linux-gnu-accel-nvptx-none-gcc -xc - -S -o- -gcoff cc1: error: target system does not support the ‘coff’ debug format So nvptx can the generic mechanism that produces such errors for all targets and all debug formats, rather than ad-hoc target-specific handling. Alexander
