On Fri, Feb 26, 2016 at 01:09:57PM -0700, Martin Sebor wrote:
> On 02/26/2016 12:51 PM, Jakub Jelinek wrote:
> >I've noticed today:
> >../../gcc/doc/extend.texi:10717: warning: `.' or `,' must follow @xref, not A
> >../../gcc/doc/extend.texi:10764: warning: `.' or `,' must follow @xref, not A
> >
> >After reading info texinfo on @xref and @pxref, I believe it is invalid
> >to use @xref this way, in the middle of a sentence, and indeed it looks
> >quite weird what is produced. So the following patch attempts to fix it up
> >by using @xref in a separate sentence. Tested on x86_64-linux, ok for
> >trunk?
>
> Thanks for fixing it up. I noticed the warning yesterday and have
> been meaning to look into it.
>
> Your change seems fine to me though I wonder if using a plain @ref{}
> instead would do the right thing. It's used in a bunch of places to
> refer to the Common Function Attributes section (for example). That
> way the referenced text wouldn't need to be repeated.
It would read as
See C99 Section x.y [Variable Length], page NN Arrays offer
in the pdf
and
See C99 *note Variable Length:: Arrays offer
if I read the texinfo doc right. Both look just too weird to me.
Jakub
