Gabriel Charette <gch...@google.com> writes: > Ian: can you approve the go changes in this patch?
The changes to the Go frontend are fine, but they need to be applied to the master repository for the Go frontend. I can take care of that when you are ready to commit the patch. Note that changes to the files in gcc/go/gofrontend do not get ChangeLog entries. > As a side thought, I'm getting random failures in the go test suite, > in my last run the difference was that > go.go-torture/execute/select-1.go failed in the clean build test and > passed in the patched build... > > Every full test run I do I get different sets of differences, I've had > identical runs too, I highly doubt this is due to my patch. I'm sure it has nothing to do with your patch. I have not seen other people report this, though. Some of the tests in the Go testsuite use a lot of threads, like thousands. It's possible that that is running into some limit on your machine. This would be particularly applicable if you are running the testsuite with make -j. Ian
