On Thu, 2016-02-18 at 18:26 +0100, Tom de Vries wrote:
> On 18/02/16 16:43, Tom de Vries wrote:
> > On 18/02/16 16:27, Richard Biener wrote:
> > > > > > I would be nice if we could avoid the ${1,2,3} printouts
> > > > > > and value
> > > > > > > > > > history
> > > > > > > > > > assignments, but I'm not sure how to do that.
> > > > > > > > > >
> > > >
> > > >
> > > > Using gdb.parse_and_eval does the trick.
> > > >
> >
> > This updated version uses gdb.parse_and_eval, and adds error
> > handling.
>
> And this updated version adds handling different number of arguments,
> and a help text. I think this could be ready for committing.
>
> Is a bootstrap/regtest useful/necessary?
I don't think so; I don't think we have any automated coverage for
gdb_hooks.py. Presumably you've tested it by hand.
What version of Python do you have embedded in gdb? (IIRC some people
have Python 2, others Python 3)
> + print ("Too little arguments")
Nit: can you change this to "Not enough arguments".
> OK for stage4/stage1?
Looks reasonable to me.
